-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4 support added #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation linting problems will need to be fixed prior to merge here - this is due to CI improvements and unrelated to your patch.
Please also sign off your commits as per https://github.com/laminas/.github/blob/main/CONTRIBUTING.md#commit-signoffs
Signed-off-by: Atul-glo35265 <glo35265@adobe.com>
Signed-off-by: Atul-glo35265 <glo35265@adobe.com>
161f960
to
d046637
Compare
All implicit nulls need dealing with here. There's also a blocker in |
Signed-off-by: Atul-glo35265 <glo35265@adobe.com>
Hi @gsteel, To fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you bump a dependency, you must also update the lock file otherwise CI will fail across the board.
6189610
to
fa34b3a
Compare
I think bumping dependency will not work here, due to other dependencies. Please check this comment and advise. |
Looks like a release of MVC 3.8.0 is required before upgrading to 8.4 here is possible |
@gsteel, can you please confirm, when |
e9e13b1
to
fa34b3a
Compare
You need to bump the minimum version of PHPUnit 10 to the most recent version in the 10.x series. I will also need to fix docs linting issues in a different patch. |
Signed-off-by: Atul-glo35265 <glo35265@adobe.com>
I've updated the phpunit10 version to 10.5.36. |
There are still a lot of implicit null params in src and tests here, along with code in dependencies, specifically MVC which you've already fixed in laminas/laminas-mvc#172 - This patch will need to wait for a release of MVC as well as fixing any remaining compatibility issues directly in view src and tests. |
@Atul-glo35265 , When these changes will be merged ? |
This has been handled in #255 thanks @Atul-glo35265 |
Description